[Dashboard] Feature: Updated Claimable #5413
Conversation
GWSzeto
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5413 +/- ##
=======================================
Coverage 45.52% 45.52%
=======================================
Files 1070 1070
Lines 55665 55665
Branches 4030 4030
=======================================
Hits 25341 25341
Misses 29637 29637
Partials 687 687
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
...rd/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/Claimable.tsx
Show resolved
Hide resolved
...rd/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/Claimable.tsx
Show resolved
Hide resolved
...rd/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/Claimable.tsx
Show resolved
Hide resolved
GWSzeto
force-pushed
the
claimable-updates
branch
from
f55a0a5 to
9943ee1
Compare
GWSzeto
force-pushed
the
claimable-updates
branch
from
9943ee1 to
f86d9bd
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
...rd/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/modules/components/Claimable.tsx
Show resolved
Hide resolved
|
The messaging in "No Claim Condition Set" alert is a bit confusing - there is no "Set claim condition" button. We should not show the form at all when there is no claim condition set. It should be just Alert + Add claim condition button and we show the form and remove the alert when you click on "Add claim condition" button 
|
GWSzeto
force-pushed
the
claimable-updates
branch
from
a547d59 to
c351781
Compare
Merge activity
|
- tokenId and setToken introduced at the parent level ClaimableModule - Claim Conditions are fetched at the parent level https://linear.app/thirdweb/issue/DES-251/claimable-erc721-erc1155-erc20 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the `ClaimableModule` functionality by refining claim conditions, improving token ID handling, and updating UI components for better user experience. ### Detailed summary - Updated claim condition checks for `ClaimableModule`. - Added `tokenId` state management in `ClaimableModule`. - Modified claim condition logic to handle ERC721 and ERC1155 tokens. - Enhanced UI with a new checkbox for "No Claim Condition Set". - Improved currency selection logic in `CurrencySelector`. - Refined `pricePerUnit` handling in `claimable.stories.tsx`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
claimable-updates
branch
from
c351781 to
92e55c8
Compare
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
https://linear.app/thirdweb/issue/DES-251/claimable-erc721-erc1155-erc20
PR-Codex overview
This PR primarily modifies the
Claimablemodule and related components to enhance functionality and improve user experience by adding token ID management and updating claim conditions.Detailed summary
ClaimableModuleto check for "Claimable" instead of "Claimable-ignore".CurrencySelectorfor checkinginitialValue.tokenIdandnoClaimConditionSetstate management inclaimable.stories.tsx.getClaimConditionErc1155Stubfunction.noClaimConditionSetin the UI.tokenIdvalidation.ClaimableModulewith new state and props for token ID management.ClaimableModuleUIto handle token ID input and validation.ClaimConditionSectionto check for claim conditions and manage form state.